Use of class notation for data_class option in forms

[tobske]

No description provided.

[javiereguiluz]

👍 (but the branch should be 3.0 instead of master)

A question to doc maintainers: since ::class requires PHP 5.5, should we update the docs anyway or wait a bit before doing that? Thanks! Nevermind: Symfony 3.x itself requires PHP 5.5+, so it's safe for docs to use 5.5 features.

[snoek09]

Thanks @tobske 👍

Status: reviewed.

[xabbuh]

Actually, I am 👎 on this change (as long as we do not use this in older versions too). Having the class notation only in newer versions will lead to conflicts when merging branches up for no real added value.

@weaverryan @wouterj What do you think?

[weaverryan]

@xabbuh I disagree, only because the :: syntax is the only usable way to use the forms (thanks to auto-completion from IDE's). Unfortunately, I think we should bear the burden for the merge conflicts :).

👍

[wouterj]

I agree with @weaverryan here. There is a significant readability improvement here. 👍

[xabbuh]

Fair enough, what do you think if we made those changes for the 2.8 docs then? People who still do not use PHP 5.5 will probably be able to figure out what to use instead, won't they?

[stof]

I tend to agree with @xabbuh here.

Btw, the class notation is supported in PHP 5.5. so people having to figure it out are users of PHP 5.3 or 5.4, which are both EOLed.

[wouterj]

👍 for 2.8 docs

[javiereguiluz]

Closing it in favor of #7157 which applies this change in 2.8 branch.

@tobske I'm sorry but I couldn't reuse your original commits because the Symfony Docs changed their internal structure completely since you created this PR.

[tobske]

@javiereguiluz No problem, I just wanted to give some input.