custom error pages - Reference to security functions warning is no more #6771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re in 2.8 In the example code of the custom error page, there was a comment reference to the `Avoiding Exceptions when Using Security Functions in Error Templates' section, that lived in the pre-2.8 documentation. That subsection is no longer there.
|
👍 Status: Reviewed |
wouterj
added a commit
that referenced
this pull request
Aug 5, 2016
This PR was submitted for the master branch but it was merged into the 2.8 branch instead (closes #6850). Discussion ---------- Remove outdated reference Finishes #6771 Original description: > In the example code of the custom error page, there was a comment reference to the `Avoiding Exceptions when Using Security Functions in Error Templates' section, that lived in the pre-2.8 documentation. That subsection is no longer there. Commits ------- 21fcb72 custom error pages - Reference to security functions warning is no more in 2.8
|
Hi @hvt! Thank you updating the example. It indeed looks like we forgot to remove this reference. As we recently restructured the docs, there was a problem merging this PR. I've taken your commit, applied it on the new structure and created (and merged) #6850 . In short: Your change is now in the documentation and you're the author of that change. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference to security functions warning is no longer needed in > 2.8.
In the example code of the custom error page, there was a comment reference to the `Avoiding Exceptions when Using Security Functions in Error Templates' section, that lived in the pre-2.8 documentation. That subsection is no longer there.