Removing the alias stuff - not required after symfony/symfony#17074 #6746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Make sure to use the 'alias_name' when you have configured your validator as a service. Otherwise your validator class | ||
| will be simply instantiated without your dependencies. | ||
| In earlier versions of Symfony, the tag required an ``alias`` key (usually set | ||
| to the class name). This is still allowed your constraint's ``validateBy`` |
There was a problem hiding this comment.
this sentence is missing something between "This is still allowed" and "your constraint's [...]". Maybe "and" or a comma or just a rewording :)
Also, it should be validateBy() (we suffix all methods mentioned by parenthesis)
|
Status: Reviewed |
weaverryan
force-pushed
the
custom_constraint_tweak
branch
from
f0cec18 to
31afb0e
Compare
weaverryan
added a commit
that referenced
this pull request
Aug 2, 2016
…ymfony#17074 (weaverryan) This PR was merged into the 2.7 branch. Discussion ---------- Removing the alias stuff - not required after symfony/symfony#17074 Thanks to symfony/symfony#17074 (merged all the way back into 2.3), `alias` is not required anymore. So why mention it? As I understand it, validators work like the new form types: it's ok that `validatedBy returns a class name: the validation system will notice that you have a tagged service matching this class and will use that instead of creating it new. Commits ------- 31afb0e line break 2ec049d Removing the alias stuff - not required after symfony/symfony#17074
| will be simply instantiated without your dependencies. | ||
| In earlier versions of Symfony, the tag required an ``alias`` key (usually set | ||
| to the class name). This is still allowed your constraint's ``validateBy`` | ||
| method can return this alias (instead of a class name). |
There was a problem hiding this comment.
@weaverryan The last sentence reads weird. Was it meant to be this way?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to symfony/symfony#17074 (merged all the way back into 2.3),
aliasis not required anymore. So why mention it?As I understand it, validators work like the new form types: it's ok that `validatedBy returns a class name: the validation system will notice that you have a tagged service matching this class and will use that instead of creating it new.