Skip to content

[Contributing][Code] fix list item terminators #6667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 21, 2016
Merged

[Contributing][Code] fix list item terminators #6667

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions contributing/code/standards.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ Structure

* Declare public methods first, then protected ones and finally private ones.
The exceptions to this rule are the class constructor and the ``setUp`` and
``tearDown`` methods of PHPUnit tests, which should always be the first methods
``tearDown`` methods of PHPUnit tests, which must always be the first methods
to increase readability;

* Declare all the arguments on the same line as the method/function name, no
Expand All @@ -169,11 +169,11 @@ Structure
* Use parentheses when instantiating classes regardless of the number of
arguments the constructor has;

* Exception and error message strings should be concatenated using :phpfunction:`sprintf`.
* Exception and error message strings must be concatenated using :phpfunction:`sprintf`;

* Calls to :phpfunction:`trigger_error` with type ``E_USER_DEPRECATED`` should be
* Calls to :phpfunction:`trigger_error` with type ``E_USER_DEPRECATED`` must be
switched to opt-in via ``@`` operator.
Read more at :ref:`contributing-code-conventions-deprecations`;
Read more at :ref:`contributing-code-conventions-deprecations`.

Naming Conventions
------------------
Expand Down