Block prefix ambiguity #6636
Closed
Block prefix ambiguity #6636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… one (WouterJ) This PR was squashed before being merged into the 2.3 branch (closes symfony#6040). Discussion ---------- Remove old File Upload article + improve the new one | Q | A | --- | --- | Doc fix? | yes | New docs? | yes | Applies to | 2.3+ | Fixed tickets | symfony#5375 The old file upload article wasn't good, a new one was written by @javiereguiluz but the old one remained online. This PR removes the old one and documents the missing bits in the new article. Commits ------- 888c61c Remove old File Upload article + improve the new one
* 2.3: Remove old File Upload article + improve the new one Conflicts: cookbook/doctrine/file_uploads.rst
| .. caution:: | ||
|
|
||
| When the name of your form class matches any of the built-in field types, | ||
| your form might not be rendered correctly. A form |
There was a problem hiding this comment.
... might not be rendered ... -> ... won't be rendered ...
| @@ -1122,6 +1122,23 @@ the choice is ultimately up to you. | |||
| )); | |||
| } | |||
|
|
|||
| .. caution:: | |||
|
|
|||
| When the name of your form class matches any of the built-in field types, | |||
There was a problem hiding this comment.
This does not only apply to the built-in types, but is also true for any other form type that is coming from third-party bundles/libraries.
|
@javiereguiluz @xabbuh all done. |
|
@foaly-nr1 when you base your branch on 2.7, you should also select 2.7 as the target branch for the PR. Otherwise, the diff gets weird and the review is harder |
|
Sorry my bad. Closing this to target |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the reasoning behind this note please see issue symfony/symfony#18953.
I based my branch on
2.7as this is when the issue first arose.