Skip to content

Change "2.3" to "2.7" as Symfony 2.3 has reached End of Maintenance #6630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Change "2.3" to "2.7" as Symfony 2.3 has reached End of Maintenance #6630

wants to merge 1 commit into from

Conversation

dword-design
Copy link

For security issues "2.3" still remains.

@@ -113,7 +113,9 @@ Choose the right Branch
Before working on a patch, you must determine on which branch you need to
work:

* ``2.3``, if you are fixing a bug for an existing feature or want to make a
* ``2.3``, for security issues;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

technically, you should not be working on security issues in the open. Work on security issues happens through a different process than the one described in this documentation page (due to being handled privately)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, let's remove this about security fixes. We already have some warnings explaining how to deal with security issues.

@stof
Copy link
Member

stof commented Jun 1, 2016

shouldn't this change be applied in the 2.7 branch ?

@dword-design
Copy link
Author

Ah yes probably. Do I need to do anything or can the symfony contributors correct it?

@stof
Copy link
Member

stof commented Jun 1, 2016

if it does not conflict when rebasing (which is likely to be fine as this page should be the same in all branches), the doc maintainers can do it when merging (the PR won't appear as merged on github because we would actually merge as rebased version of the branch, and so a different commit hash than the one in your PR even though the patch would be the same)

@xabbuh
Copy link
Member

xabbuh commented Jun 1, 2016

@Dword123 Thank you for noticing this and for also preparing a pull request. Sadly, I still have to close here as your changes will already be taken care of in #6626. I am nonetheless looking forward to your next contribution which will hopefully make it into the documentation. :)

@xabbuh xabbuh closed this Jun 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants