Skip to content

6555 link to Download instructions page & Windows executable #6585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

6555 link to Download instructions page & Windows executable #6585

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a81295f
6555 link to Download instructions page for Linux / Unix / OSX instal…
May 21, 2016
9ea6493
6555 code review changes
May 21, 2016
4ffdece
6555 indent code-block, add semi-colon at list item end
May 21, 2016
744a4c3
6555 fix indent
May 21, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 4 additions & 15 deletions cookbook/composer.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,28 +14,18 @@ following sections.
Install Composer on Linux and Mac OS X
--------------------------------------

To install Composer on Linux or Mac OS X, execute the following two commands:
Run the installer following the Download page instructions from https://getcomposer.org/download.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should keep a real link to this resource imo.

Copy link
Member

@wouterj wouterj May 21, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about using steps here and using nice link names?

#. Run the installer as described in `the official Composer documentation`_.
#. Execute the following command to move the `composer.phar` to a directory
   that is in your path:

   .. code-block:: bash

       ...


.. at the bottom of the file, add:

 .. _the official Composer documentation: https://getcomposer.org/download


After this you can run this command to move composer.phar to a directory that is in your path:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the filename should be enclosed by literals (double backticks)


.. code-block:: bash

$ curl -sS https://getcomposer.org/installer | php
$ sudo mv composer.phar /usr/local/bin/composer
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please indent this block with 3 spaces (this way, it's part of the second item of the list)


.. note::

If you don't have ``curl`` installed, you can also just download the
``installer`` file manually at https://getcomposer.org/installer and
then run:

.. code-block:: bash

$ php installer
$ sudo mv composer.phar /usr/local/bin/composer

Install Composer on Windows
---------------------------

Download the installer from `getcomposer.org/download`_, execute it and follow
Download the installer from https://getcomposer.org/Composer-Setup.exe, execute it and follow
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would change to something like "Download Composer-Setup.exe_, execute [...]" and then add the full URL reference at the bottom to have a link that looks nice.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use a link name here as well (Download the installer from getcomposer.org_, execute it and follow the instructions.

Then at the bottom of the page, add .. _getcomposer.org: https://getcomposer.org/Composer-Setup.exe

the instructions.

Learn more
Expand All @@ -44,5 +34,4 @@ Learn more
Read the `Composer documentation`_ to learn more about its usage and features.

.. _`Composer`: https://getcomposer.org/
.. _`getcomposer.org/download`: https://getcomposer.org/download
.. _`Composer documentation`: https://getcomposer.org/doc/00-intro.md