Skip to content

Minor update to Symfony version for method override #6221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

sfdumi
Copy link
Contributor

@sfdumi sfdumi commented Feb 3, 2016

Minor update to Symfony version for method override, when presenting since the method is available.

Minor update to Symfony version for method override, when presenting since the method is available.
@OskarStark
Copy link
Contributor

not wrong, but not sure if this is necessary

@xabbuh
Copy link
Member

xabbuh commented Feb 6, 2016

I think we should reword the whole sentence to only explain that this feature is enabled by default. We can then merge this change into the 2.7 branch where we also do not have any versionadded directives for Symfony 2.2.

@wouterj
Copy link
Member

wouterj commented Jul 8, 2016

Hi @sfdumi! As Symfony 2.3 is no longer maintained and 2.7 (the oldest still maintained version) doesn't document 2.2 changes, I've changed this note to a small tip showing the new option in #6735

With that, I'm going to close this PR as we can't apply it to the docs anymore. Sorry for ignoring this PR for so long.

@wouterj wouterj closed this Jul 8, 2016
wouterj added a commit that referenced this pull request Jul 9, 2016
This PR was merged into the 2.7 branch.

Discussion
----------

Change _method parameter versionadded note

Replaces #6221

Commits
-------

567ef6a Change note, as 2.7 doesn't document 2.2 changes.
ef556a8 Minor update to Symfony version for method override
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants