-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
use same route for login_path and check_path #6143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
snoek09
wants to merge
3
commits into
symfony:2.3
from
snoek09:use-same-route-for-check-path-and-login-path
Closed
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -129,10 +129,10 @@ Each part will be explained in the next section. | |
provider: some_key_from_above | ||
form_login: | ||
# submit the login form here | ||
check_path: /login_check | ||
check_path: login | ||
|
||
# the user is redirected here when they need to log in | ||
login_path: /login | ||
login_path: login | ||
|
||
# if true, forward the user to the login form instead of redirecting | ||
use_forward: false | ||
|
@@ -252,7 +252,7 @@ The Login Form and Process | |
login_path | ||
.......... | ||
|
||
**type**: ``string`` **default**: ``/login`` | ||
**type**: ``string`` **default**: ``login`` | ||
|
||
This is the route or path that the user will be redirected to (unless ``use_forward`` | ||
is set to ``true``) when they try to access a protected resource but isn't | ||
|
@@ -265,7 +265,7 @@ you may create a redirect loop. For details, see | |
check_path | ||
.......... | ||
|
||
**type**: ``string`` **default**: ``/login_check`` | ||
**type**: ``string`` **default**: ``login`` | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this (and above) is wrong, the default set in the MainConfiguration class of SecurityBundle is still |
||
|
||
This is the route or path that your login form must submit to. The firewall | ||
will intercept any requests (``POST`` requests only, by default) to this | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ough, this will be hard to learn to new users:
/login
has to be not secured, but behind a firewall... However, I think we cannot do anything about it.