[Cookbook] Make registration_form follow best practices #6073
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @ORM\Column(type="string", length=64) | ||
| * @ORM\Column(type="string", length=255) | ||
| * @Assert\NotBlank() | ||
| * @Assert\Length(max=4096) |
There was a problem hiding this comment.
This is useless imo as we do not store the plain password.
|
I agree with the changes asked by @xabbuh, but they would mean a lot of modifications in the current article. That's why I'm closing this pull request. |
|
Alright, I opened #4773 again to not forget about this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a rebase of #4773 to make it mergeable.