Skip to content

Update securing_services.rst #5869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update securing_services.rst #5869

wants to merge 1 commit into from

Conversation

aruku
Copy link

@aruku aruku commented Nov 7, 2015

I'm pretty sure the file mentioned in the last info box is app/config/config.yml and not services.yml;
there will probably be a similar issue in the other formats (XML and PHP) but I don't use them so I don't know for sure.

Also, it goes back all the way to the first version of the docs, for SF 2.3.

I'm pretty sure the file mentioned in the last info box is ```app/config/config.yml``` and not ```services.yml```;
there will probably be a similar issue in the other formats (XML and PHP) but I don't use them so I don't know for sure.

Also, it goes back all the way to the first version of the docs, for SF 2.3.
@javiereguiluz
Copy link
Member

I'm not sure about this change. The app/config/services.yml file is where modern Symfony applications define their services. We introduced this change a year ago alongside the official best practices. Most of the documentation has been updated to use this file. So I guess we should do the same here.

@aruku
Copy link
Author

aruku commented Nov 7, 2015

@javiereguiluz This is not defining services, is configuring a bundle.

@xabbuh
Copy link
Member

xabbuh commented Nov 7, 2015

The change looks valid to me.

@aruku Can you also update the file names for the other configuration formats?

@javiereguiluz
Copy link
Member

@aruku you are right. I'm sorry.

@aruku
Copy link
Author

aruku commented Nov 7, 2015

@xabbuh Done. I did it for the 4 versions this doc is linked to in the website.
These are the PRs: #5870, #5871, #5872 and #5873. (This last one does the change I did in here too, I didn't realize I could have done it here, sorry!)

@xabbuh
Copy link
Member

xabbuh commented Nov 8, 2015

closing in favour of #5870

@xabbuh xabbuh closed this Nov 8, 2015
@aruku aruku deleted the patch-1 branch November 8, 2015 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants