Skip to content

internal web server ran with dev environment by default #5612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

rmed19
Copy link
Contributor

@rmed19 rmed19 commented Aug 10, 2015

Q A
Doc fix? yes
New docs? no
Applies to 2.3+
Fixed tickets #5611

@javiereguiluz
Copy link
Member

@rmed19 thanks for submitting this pull request!

I like the idea that you propose here. However, the title of the changed sidebar is "What's the app_dev.php in the URL?" So we should probably introduce more changes to completely update this explanation. In any case, before doing any other change, let's wait to know the opinion of the doc managers @wouterj and @xabbuh.

@xabbuh
Copy link
Member

xabbuh commented Aug 17, 2015

We could remove the app:dev.php front controller from the URL as you will probably start the internal web server in the dev environment. The sidebar Javier mentions is then no longer necessary. We could replace it with another one named something like "Accessing different Environments". Here we can explain how to access your application in different environments through the built-in web server. What do you think?

@rmed19
Copy link
Contributor Author

rmed19 commented Aug 19, 2015

Hi,
We shold remove all app_dev.php from internal web server url in this chapter, not only one url like I did.
IMO the sidebar haven't any more sense it should be removed or changed to some thing else

@wouterj
Copy link
Member

wouterj commented Feb 6, 2016

Hi @rmed19! I've taken your commits and put them in a new PR, updating all examples in the page creation book and the sidebar: #6239 I'm going to close this PR in favor of this one (your commit is included, so you'll get all credits for finding this inconsistentcy!).

Thank you for submitting an issue and PR and helping us improve one of the most important articles of the docs (first impression is everything).

@wouterj wouterj closed this Feb 6, 2016
xabbuh added a commit that referenced this pull request Feb 7, 2016
This PR was merged into the 2.3 branch.

Discussion
----------

Remove app_dev as build-in server is used

Finishes/replaces #5612

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | 2.3+
| Fixed tickets | #5611

Commits
-------

6dfeb9a Remove app_dev.php as buildin server is used
51659f1 internal web server ran with dev environment by default
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants