[Cookbook][Cache] Fix cookie example on Varnish cookbook #5605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have realized that the example which unsets unnecesary cookies it's wrong and mixes Varnish 3 and 4 syntax, so I've separate the current example in two, one for each version.
Fix configuration-block/code-block syntax
| } | ||
| } | ||
| } | ||
| .. code-block:: varnish4 |
There was a problem hiding this comment.
the indentation should be 4 spaces, not 2
There was a problem hiding this comment.
Sorry, thanks for commenting :)
Fix identation
csuarez
changed the title
|
looks good! older versions of the doc do not have this example so i guess the 2.7 branch is also the right one. |
|
@dbu Do you remember if there was a good reason not to put these examples into older branches? |
|
no idea. but 2.7 being the lts this seems good enough. afaik that whole
article was rewritten.
|
|
looks the same, yes. this PR can be closed. |
|
@xabbuh Yes, I've checked it and it's the same 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have realized that the example which unsets unnecesary cookies it's wrong and mixes Varnish 3 and 4 syntax, so I've separate the current example in two, one for each version.