Skip to content

[Cookbook][Controller] few tweaks to the error pages article #5309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 31, 2015
Merged

[Cookbook][Controller] few tweaks to the error pages article #5309

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cookbook/controller/error_pages.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ is used to render a Twig template to show the user.

.. _cookbook-error-pages-by-status-code:

This controller uses the HTTP status code, request format and the following
This controller uses the HTTP status code, the request format and the following
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if this is needed. For me (but maybe because I'm dutch), the original sentence is easier to read.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Imho it reads odd the way it is now. If we omitted "the" here, we should remove it before "following logic" too. Let's see what Ryan thinks about this.

logic to determine the template filename:

#. Look for a template for the given format and status code (like ``error404.json.twig``
Expand Down Expand Up @@ -79,7 +79,7 @@ A typical project that returns HTML and JSON pages, might look like this:
├─ error.html.twig # All other HTML errors (including 500)
├─ error404.json.twig
├─ error403.json.twig
├─ error.json.twig # All other JSON errors (including 500)
└─ error.json.twig # All other JSON errors (including 500)

Example 404 Error Template
--------------------------
Expand Down