improved description of choice_list option of Choice form type

[adamziel]

Current example could be a bit confusing since rendered HTML would look like this:

<select>
    <option value="0">Full</option>
    <option value="1">Half</option>
</select>

Which could easily be confued with truncated floats. In other words this is very similar to what would happen if choices option was set to array(1=>'Full', 0.5=>'Half'). This pull request is an attempt to give a clue "a-ha, it's an index and not a float representation".

[dupuchba]

👍

[wouterj]

👍

[weaverryan]

This is a nice addition, because as I was reading this, I was in fact confused as you described in the PR description :). Can we add one more line after this? I'd like something that basically says: "But don't be confused! If Full is selected (value 0 in HTML), 1 will be returned in your form. If Almost empty is selected (value 2 in HTML), 2 will be returned".

[xabbuh]

@adamziel Will you be able to make the change requested by @weaverryan?

[javiereguiluz]

I'm finishing this PR in #5428.

@adamziel don't worry about not having finished your PR. This happens sometimes. I've taken your work and finished in another PR. I've also reused all your original commits so you get the credit for your work. Thanks.

[weaverryan]

Great - thank you @javiereguiluz! The commit from @adamziel will be merged in with #5428 :)

[adamziel]

Thanks!