Skip to content

Minor improvement for symfony-installer with LTS #5032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions book/installation.rst
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,17 @@ number as the second argument of the ``new`` command:
# Windows
c:\projects\> php symfony.phar new my_project_name 2.3.23

If you want your project to be based on the last Symfony LTS version, pass
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it better to use "latest" instead of "last"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest could be interpreted as "they are a lot of LTS versions", but there is only one
For me last is ok, or nothing at all

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, if you look at each patch version as its own version, there are a lot of LTS versions. However, at least this will be true when Symfony 2.7 is released because we then have two LTS versions.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC what my English teachers told me, last would mean that there won't be any other LTS version after this one, which is wrong.
But I will let a native speaker confirm this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand your point of view
Can you confirm that https://github.com/symfony/symfony-installer/blob/master/src/Symfony/Installer/NewCommand.php#L223 will download automatically the 2.7 when it will be published, even if the 2.3 will still be maintained?
If yes, latest is the best option imo

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@94noni I can confirm that lts will always be the most recent LTS version (2.3 today and 2.7 in a few months). This version switch will be transparent to the installer and it will be done immediately after the new LTS version is published.

``lts`` as the second argument of the ``new`` command:

.. code-block:: bash

# Linux, Mac OS X
$ symfony new my_project_name lts

# Windows
c:\projects\> php symfony.phar new my_project_name lts

Read the :doc:`Symfony Release process </contributing/community/releases>`
to better understand why there are several Symfony versions and which one
to use for your projects.
Expand Down