Skip to content

File extension fix for xml validation example #4965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

hansstevens
Copy link
Contributor

Q A
Doc fix? yes
New docs? no
Applies to all
Fixed tickets ~

@wouterj
Copy link
Member

wouterj commented Feb 6, 2015

Good catch! Can you please rebase your PR, it seems to conflict.

If you don't know how to rebase: (assuming origin is this repository and hansstevens is your fork)

$ git checkout improve_doctrine_fileupload
$ git fetch origin
$ git rebase origin/2.3
$ git push hansstevens -f improve_doctrine_fileupload

@hansstevens
Copy link
Contributor Author

Thanks for your help! It should be ok now..

Regards

@wouterj
Copy link
Member

wouterj commented Feb 14, 2015

Something was still wrong, so I cherry picked your commit into a new PR: #4995
I've now merged that PR. Thank you for the fix!

@wouterj wouterj closed this Feb 14, 2015
wouterj added a commit that referenced this pull request Feb 14, 2015
This PR was merged into the 2.3 branch.

Discussion
----------

[#4965] file extension fix

Rebased version of #4965

Commits
-------

f89908d file extension fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants