Changed the namespaces of form related classes in the bundle #496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The types are now placed in Form\Type and the form-specific non-persisted models in Form\Model to keep the namespace organized
|
+1 to make things clear. |
weaverryan
added a commit
that referenced
this pull request
Jul 5, 2011
Changed the namespaces of form related classes in the bundle
|
I've merged this in - seems like a solid change and nobody has raised any concerns to this convention. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The types are now placed in Form\Type and the form-specific non-persisted
models in Form\Model to keep the namespace organized.
This is related to the discussion on #433 and @weaverryan agreed that Form\Model is a good idea.
I add the fact that many people are asking where they should place them so providing such a convention would be good. Once we agree on the naming, I will do the change in FOSUserBundle.