Skip to content

[Book][Translation] Added tip for routing params #4803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 25, 2015

Conversation

xelaris
Copy link
Contributor

@xelaris xelaris commented Jan 9, 2015

Q A
Doc fix? no
New docs? no
Applies to 2.3+
Fixed tickets

@xabbuh
Copy link
Member

xabbuh commented Jan 9, 2015

👍

.. tip::

Read :doc:`/cookbook/routing/service_container_parameters` to learn, how to
avoid hardcoding the ``_locale`` requirement in all your routes.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a question about the use of the word requirement in this tip. Are you referring to a real route requirement option or are you using it as a regular word? If that's the case, we could change it to avoid confusions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took it from the referenced entry

You could hardcode your _locale requirement in all your routes [...]

For me it's referring to the route option but I understand your question, it is maybe also interpretable as the regular word. As a non-native speaker I would say, the sentence is still valid then, isn't it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is exactly about route requirements as in the example route above, isn't it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's right.

@xelaris
Copy link
Contributor Author

xelaris commented Jan 18, 2015

@wouterj I removed the comma in the new tip and in another one for consistency.

@weaverryan
Copy link
Member

Nice addition - thanks Alexander!

@weaverryan weaverryan merged commit acb5868 into symfony:2.3 Jan 25, 2015
weaverryan added a commit that referenced this pull request Jan 25, 2015
This PR was merged into the 2.3 branch.

Discussion
----------

[Book][Translation] Added tip for routing params

| Q             | A
| ------------- | ---
| Doc fix?      | no
| New docs?     | no
| Applies to    | 2.3+
| Fixed tickets |

Commits
-------

acb5868 [Book][Translation] Added tip for routing params
@xelaris xelaris deleted the patch-18 branch October 31, 2022 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants