-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[WIP] Cookbook grammar and style fixes #4694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
4588313
9de9f70
9c7c42d
b47169c
393d50c
74ed749
aee8923
5bb1ed4
37a731e
e1c0ec2
67919d9
9064ffc
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -25,14 +25,14 @@ Routing and X-FORWARDED Headers | |
------------------------------- | ||
|
||
To ensure that the Symfony Router generates URLs correctly with Varnish, | ||
a ``X-Forwarded-Port`` header must be present for Symfony to use the | ||
an ``X-Forwarded-Port`` header must be present for Symfony to use the | ||
correct port number. | ||
|
||
This port depends on your setup. Lets say that external connections come in | ||
This port depends on your setup. Let's say that external connections come in | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. To reply to:
Hmm, I'm not really sure what we are trying to say in this chapter. But maybe something like "For instance, if external connections come in on the default HTTP port 80" or "Imagine that external connections [...]" @dbu I think you wrote this, can you please explain a bit more? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yep, i rewrote that section a few days ago. not sure what exactly is unclear. the X-Forwarded-Port needs to be set to whatever port your setup is using to receive external connections. if that would be 1234 then links will be http://example.com:1234/... the tricky bit is that varnish may be the outmost system, or there could be something else like a load balancer or firewall that re-routes to a different port. most of the time, the external port will be 80. if you are using https, varnish does not support ssl and thus needs a proxy in front of it that terminates ssl, and then the port will almost always be 443. does that help? happy to help more if i can, but would need a question or a proposal to comment on. |
||
on the default HTTP port 80. For HTTPS connections, there is another proxy | ||
(as Varnish does not do HTTPS itself) on the default HTTPS port 443 that | ||
handles the SSL termination and forwards the requests as HTTP requests to | ||
Varnish with a ``X-Forwarded-Proto`` header. In this case, you need to add | ||
Varnish with an ``X-Forwarded-Proto`` header. In this case, you need to add | ||
the following configuration snippet: | ||
|
||
.. code-block:: varnish4 | ||
|
@@ -143,7 +143,7 @@ Symfony adds automatically: | |
.. tip:: | ||
|
||
If you followed the advice about ensuring a consistent caching | ||
behaviour, those vcl functions already exist. Just append the code | ||
behaviour, those VCL functions already exist. Just append the code | ||
to the end of the function, they won't interfere with each other. | ||
|
||
.. index:: | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
`all files``would be even better