-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[WIP] Cookbook grammar and style fixes #4693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
4588313
9de9f70
9c7c42d
b47169c
393d50c
74ed749
aee8923
5bb1ed4
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,7 +7,7 @@ How to Use PdoSessionHandler to Store Sessions in the Database | |
The default Symfony session storage writes the session information to | ||
file(s). Most medium to large websites use a database to store the session | ||
values instead of files, because databases are easier to use and scale in a | ||
multi-webserver environment. | ||
multi webserver environment. | ||
|
||
Symfony has a built-in solution for database session storage called | ||
:class:`Symfony\\Component\\HttpFoundation\\Session\\Storage\\Handler\\PdoSessionHandler`. | ||
|
@@ -17,7 +17,7 @@ configuration format of your choice): | |
.. versionadded:: 2.1 | ||
In Symfony 2.1 the class and namespace are slightly modified. You can now | ||
find the session storage classes in the ``Session\Storage`` namespace: | ||
``Symfony\Component\HttpFoundation\Session\Storage``. Also | ||
``Symfony\Component\HttpFoundation\Session\Storage``. Also, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm not sure about this change. I feel that it puts too much emphasize on "also". There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @xabbuh IMHO, there has to be one: http://www.englishrules.com/writing/2005/comma-with-also/ |
||
note that in Symfony 2.1 you should configure ``handler_id`` not ``storage_id`` like in Symfony 2.0. | ||
Below, you'll notice that ``%session.storage.options%`` is not used anymore. | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
while this isn't your fault I want to note that we always try to avoid first person usage. Can we remove "Let's" here completely by rewriting this sentence?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wouterj Agreed. Do you have a concrete idea?