Skip to content

Update controllers.rst #4647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Update controllers.rst #4647

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
96a6e17
Update controllers.rst
keefekwan Dec 13, 2014
d43f720
Update controllers.rst
keefekwan Dec 16, 2014
52f504a
Update controllers.rst
keefekwan Dec 16, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions best_practices/controllers.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,8 +136,12 @@ For example:

.. code-block:: php

use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\ParamConverter;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This use statement is then also not needed.


/**
* @Route("/{id}", name="admin_post_show")
* @ParamConverter("post", class="AppBundle:Post")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, now I think of it, this isn't needed at all. The FrameworkExtraBundle will do this automatically because you typehinted to an entity. Can you please remove this change, leaving only the addition of line 139 in this PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing, removed the annotation.

*/
public function showAction(Post $post)
{
Expand Down