Skip to content

When explaining how to install dependencies for running unit tests, #4585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

When explaining how to install dependencies for running unit tests, #4585

wants to merge 1 commit into from

Conversation

carlosbuenosvinos
Copy link
Contributor

Q A
Doc fix? yes
New docs? no
Applies to all
Fixed tickets #4584

there are references to "--dev" composer parameter that is the
current default value.
@timglabisch
Copy link
Contributor

👍

@xabbuh
Copy link
Member

xabbuh commented Dec 3, 2014

Good idea @carlosbuenosvinos. Is this the only file where we use Composer with the --dev flag?

@carlosbuenosvinos
Copy link
Contributor Author

It's the only one.

2014-12-04 0:02 GMT+01:00 Christian Flothmann notifications@github.com:

Good idea @carlosbuenosvinos https://github.com/carlosbuenosvinos. Is
this the only file where we use Composer with the --dev flag?


Reply to this email directly or view it on GitHub
#4585 (comment).

Carlos Buenosvinos Zamora
carlos.buenosvinos@gmail.com
659730605

url: http://carlosbuenosvinos.com
twitter: buenosvinos
skype: carlos.buenosvinos
gtalk: carlos.buenosvinos@gmail.com

@xabbuh
Copy link
Member

xabbuh commented Dec 4, 2014

Thanks for checking.

@weaverryan
Copy link
Member

Why should we make this change? I'm sure there's a good reason - I just don't know what it is :)

Thanks!

@xabbuh
Copy link
Member

xabbuh commented Dec 7, 2014

@weaverryan The --dev option is simply not needed since it is the default (it has changed a while ago in Composer). If we kept it in the documentation, people might get the feeling that --no-dev was the default.

wouterj added a commit that referenced this pull request Dec 8, 2014
…nit tests, (carlosbuenosvinos)

This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #4585).

Discussion
----------

When explaining how to install dependencies for running unit tests,

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | all
| Fixed tickets | #4584

Commits
-------

512632e When explaining how to install dependencies for running unit tests, there are references to "--dev" composer parameter that is the current default value.
@wouterj
Copy link
Member

wouterj commented Dec 8, 2014

Thank you for spotting the code and noting that the dev option wasn't needed, Carlos! I've merged this into the 2.3 branch using 7dcce1b.

Fyi, I've also created composer/composer#3517 to avoid confusion in the future (and make it easier to spot that this option isn't used no longer).

@wouterj wouterj closed this Dec 8, 2014
@carlosbuenosvinos
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants