fixed little typo #4574
Merged
fixed little typo #4574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch @adridev |
|
Thanks, @adridev! (for the next time, it's better if you create a new branch for each PR, this means you can have multiple PRs at the same time) |
wouterj
added a commit
that referenced
this pull request
Dec 2, 2014
This PR was merged into the 2.3 branch. Discussion ---------- fixed little typo Commits ------- d43dacc fixed little typo
|
Yes, I saw it in the docs but it is so little change that I skipped the creation of a new branch. Anyway I take note and the next time I will create a new branch. Thanks! |
|
@adridev There no difference for the docs team whether or not you use a separate branch. But it's harder for you to create more than one pull request at the same time if you didn't. |
|
it is also harder for you if the doc team rebases your PR to change the target branch, because you then have a diverging history in your fork. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.