Update conventions.rst #4542
Closed
Update conventions.rst #4542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ``trigger_error``call seems to be written in one line: https://github.com/symfony/symfony/pull/12671/files
|
It's indeed a good idea to make this change even if the readability is a bit limited. But the core team prefers to have this in one line. So people can then simply copy and paste from the docs. |
|
Let's not wait on travis (as the hackday produces so many jobs, many are in the queue...) and merge this straight away. Thanks @csuarez, this will definitely help people the comming 2 hours! |
wouterj
added a commit
that referenced
this pull request
Nov 29, 2014
This PR was submitted for the 2.6 branch but it was merged into the 2.3 branch instead (closes #4542). Discussion ---------- Update conventions.rst The ``trigger_error`` call seems to be written in one line: https://github.com/symfony/symfony/pull/12671/files Commits ------- 3d75f6a Update conventions.rst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
trigger_errorcall seems to be written in one line: https://github.com/symfony/symfony/pull/12671/files