-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Book: Update link title to match cookbook article title #4530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Article title updated since c9fe05b
@@ -898,7 +898,7 @@ The extension alias (configuration key) can also be used: | |||
.. note:: | |||
|
|||
See the cookbook article: | |||
:doc:`How to expose a Semantic Configuration for a Bundle </cookbook/bundles/extension>` | |||
:doc:`How to Load Service Configuration inside a Bundle </cookbook/bundles/extension>` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'probably better if we just don't use a title here. Then, the referenced article's title will automatically be taken:
:doc:`/cookbook/bundles/extension`
Thank you for noticing and for providing a patch @dangarzon. As you have seen, simply using the documents title is a bit error prone when the referenced document's title changes. Therefore, I would suggest to simply omit the title here and let Sphinx do all the work for us. |
@xabbuh |
@dangarzon Thank you. Can you even reorder the paragraph so that uses almost all available space of a line (simply wrap lines after the first word that crosses the 72nd character). |
@xabbuh like this? |
@dangarzon Exactly 👍 |
Nice! |
Thanks Daniel! Good catch |
…dangarzon) This PR was squashed before being merged into the 2.3 branch (closes #4530). Discussion ---------- Book: Update link title to match cookbook article title | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | Article title updated in c9fe05b Commits ------- 37c29e9 Book: Update link title to match cookbook article title
Article title updated in c9fe05b