Replacing deprecated security context #4512
Conversation
The `Symfony\Component\Security\Core\SecurityContextInterface` was deprecated with symfony 2.6. All instances of this interface where replaced with `Symfony\Component\Security\Core\Authorization\AuthorizationCheckerInterface` or `Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorageInterface` depending on the use case. All instances of `SecurityContext` where replaced as well. This was done based on the blog post http://symfony.com/blog/new-in-symfony-2-6-security-component-improvements
|
I think that there is a minor error in the PR number showed in the "Fixed tickets" row. Instead of 5411, your probably wanted to display 4511. |
|
@javiereguiluz Yes, thanks for noticing. Updated! |
|
@Sgoettschkes you're going to hate me ... but I think there is again an error in the "Fixed tickets" PR number. Now it shows 4512 and you probably wanted to display 4511. |
|
@javiereguiluz Not at all. It's my fault after all. Sorry for the confusion. Checked the link, it should be ok now. |
|
@Sgoettschkes everything is perfect now. Thanks! |
|
@Sgoettschkes Thank you for your pull request. Though I think that this is already covered by #4188 which completely covers the split of the |
|
@Sgoettschkes It's indeed a good idea to check if nothing is missing in #4188 that is covered by your changes. 👍 |
|
@Sgoettschkes I think I've covered the most important things, I suggest you to fork my branch and see if there's still anything missing. I won't do any --force anymore, so you can safely use it. |
| { | ||
| $this->securityContext = $securityContext; | ||
| $this-$tokenStorage = $tokenStorage; |
|
Closing here. @Sgoettschkes feel free to ping us if you notice anything that was not covered by #4188. |
This PR turned out larger than wanted. I wasn't able to test all changes, but as stated in http://symfony.com/blog/new-in-symfony-2-6-security-component-improvements replacing should work without problems.