Removed unnecessary use statement #4445
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👎 actually the Request is used just after the use statement. So it's needed after autoload... |
|
Good. Don't we need then to add it to the first code example? |
|
I think it's okay to remove it here. If you have a look at the file contents of the Symfony Standard Edition, you'll see that the |
|
I agree with @xabbuh, +1 |
|
Yep, I agree too - because we're trying to only show the details you need to change, not everything. It's not perfect, but it makes sense to not show this here, since we're not changing or touching (or even really looking at) the Request line this relates to. Thanks @hasumedic! |
weaverryan
added a commit
that referenced
this pull request
Nov 20, 2014
This PR was merged into the 2.3 branch. Discussion ---------- Removed unnecessary use statement | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | Found a rather unnecessary "use" statement in the code example in the "debugging" cookbook. Makes it difficult to spot the changes between one code example and the following one and know what changed. Commits ------- 6a9162b Removed unnecessary use statement in code example in the debugging cookbook
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found a rather unnecessary "use" statement in the code example in the "debugging" cookbook. Makes it difficult to spot the changes between one code example and the following one and know what changed.