Correct link to scopes page #4437
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@weaverryan ping |
| @@ -87,7 +87,7 @@ service container. In other words, you have access to any configured service:: | |||
| // ... | |||
| } | |||
|
|
|||
| However, due to the `container scopes </cookbook/service_container/scopes>`_ this | |||
| However, due to the `container scopes </doc/current/cookbook/service_container/scopes.html>`_ this | |||
There was a problem hiding this comment.
The document itself was correct. It just has to use the doc role:
:doc:`container scopes </cookbook/service_container/scopes>`Can you please change it to be like that?
|
Good catch @mayeco. However, this has to be solved in another way. Can you change it according to my comment? |
change the link according to xabbuh comment
|
Thank you for your comment @xabbuh I make the changes you request me. |
|
👍 Thanks @mayeco! |
|
Awesome, thanks Mario! |
weaverryan
added a commit
that referenced
this pull request
Nov 10, 2014
This PR was submitted for the 2.5 branch but it was merged into the 2.3 branch instead (closes #4437). Discussion ---------- Correct link to scopes page The current link to scopes page dont work, this is the correct link to the page Commits ------- 7a37cb8 changes from xabbuh 434fed7 Correct link to scopes page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current link to scopes page dont work, this is the correct link to the page