Skip to content

Added interlinking and fixed install template for reusable bundles #4377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 7, 2014

Conversation

wouterj
Copy link
Member

@wouterj wouterj commented Oct 26, 2014

Q A
Doc fix? yes
New docs? no
Applies to all
Fixet tickets -

See commit descriptions for more info

.. seealso::

The best practices for application-specific bundles are discussed in a
dedicated section of the documentation: :doc:`/best_practices/introduction`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be indented by four spaces

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could write "[...] in the best practices section [...]" and link that part to it.

It seems like this one was missed when reverting the change. For the
discussion, see symfony#4290
@wouterj
Copy link
Member Author

wouterj commented Oct 31, 2014

Thanks @xabbuh ! I've fixed the indentation (I should fix my editor...) and rewroted it a bit. I think it's still good to link to the full best practices.


The best practices for application-specific bundles are discussed in
:doc:`/best_practices/introduction`.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

like this - good link

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should just keep in mind not to merge this before the best practices chapter is rendered properly.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you just mean the bad styling on the "best practice" items? Or is there something else. I wouldn't let the first thing block us :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were some more style issues and I ink even some images weren't loaded. But this seems to be fixed: http://symfony.com/doc/current/best_practices/introduction.html

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue is #4383.

@weaverryan weaverryan merged commit 35d8e5f into symfony:2.3 Nov 7, 2014
weaverryan added a commit that referenced this pull request Nov 7, 2014
…ble bundles (WouterJ)

This PR was merged into the 2.3 branch.

Discussion
----------

Added interlinking and fixed install template for reusable bundles

| Q   | A
| --- | ---
| Doc fix? | yes
| New docs? | no
| Applies to | all
| Fixet tickets | -

See commit descriptions for more info

Commits
-------

35d8e5f Reverted removal of version
94f04a4 Added interlinking between the 2 best practices
@wouterj wouterj deleted the bundle_practices branch November 7, 2014 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants