-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Added interlinking and fixed install template for reusable bundles #4377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
.. seealso:: | ||
|
||
The best practices for application-specific bundles are discussed in a | ||
dedicated section of the documentation: :doc:`/best_practices/introduction` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be indented by four spaces
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could write "[...] in the best practices section [...]" and link that part to it.
It seems like this one was missed when reverting the change. For the discussion, see symfony#4290
d5122c4
to
35d8e5f
Compare
Thanks @xabbuh ! I've fixed the indentation (I should fix my editor...) and rewroted it a bit. I think it's still good to link to the full best practices. |
|
||
The best practices for application-specific bundles are discussed in | ||
:doc:`/best_practices/introduction`. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
like this - good link
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should just keep in mind not to merge this before the best practices chapter is rendered properly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you just mean the bad styling on the "best practice" items? Or is there something else. I wouldn't let the first thing block us :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There were some more style issues and I ink even some images weren't loaded. But this seems to be fixed: http://symfony.com/doc/current/best_practices/introduction.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue is #4383.
…ble bundles (WouterJ) This PR was merged into the 2.3 branch. Discussion ---------- Added interlinking and fixed install template for reusable bundles | Q | A | --- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixet tickets | - See commit descriptions for more info Commits ------- 35d8e5f Reverted removal of version 94f04a4 Added interlinking between the 2 best practices
See commit descriptions for more info