Skip to content

[Components][HttpFoundation] Make a small grammatical adjustment #4276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 15, 2014
Merged

[Components][HttpFoundation] Make a small grammatical adjustment #4276

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/http_foundation/session_configuration.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ which runs reasonably frequently. The ``cookie_lifetime`` would be set to a
relatively high value, and the garbage collection ``gc_maxlifetime`` would be set
to destroy sessions at whatever the desired idle period is.

The other option is to specifically checking if a session has expired after the
The other option is specifically checking if a session has expired after the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm far from native, so I can be completely wrong, but isn't "The other option is to specifically check if a session has expired after the session is started." better?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FTR, English is not my native language either.

Actually, yes, as I wrote it in the commit message and PR description, I think both the infinitive form and the gerund form are grammatically correct, and, in this context, either may be used as subject complement (but I might also be wrong).

I guess the infinitive form is a bit more literary (although this is very subjective), which is less suitable in a context of technical documentation, and that's why I chose the gerund form in my commit.

Obviously, I'd be willing to commit again with the infinitive form if it's considered a better fit.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tend to agree with @wouterj here. But I'm also no native speaker. So, let's wait for @weaverryan for the final decision.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, @wouterj is right. To be clear, the language is wrong as it currently is. The best is:

The other option is to specifically check if a session has expired after the session is started.

session is started. The session can be destroyed as required. This method of
processing can allow the expiry of sessions to be integrated into the user
experience, for example, by displaying a message.
Expand Down