Skip to content

added Nicolas to the list of mergers for the new var dumper component #4275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 26, 2014
Merged

added Nicolas to the list of mergers for the new var dumper component #4275

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions contributing/code/core_team.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,8 @@ Active Core Members
* **Romain Neutron** (:merger:`romainneutron`) can merge into the
Process_ component;

* **Nicolas Grekas** (:merger:`nicolas-grekas`) can merge into the Debug_
component;
* **Nicolas Grekas** (:merger:`nicolas-grekas`) can merge into the Debug_ and
VarDumper_ components, and into the DebugBundle_ bundle;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the serial comma before "and" has to be removed to comply with our standards

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought that first too. But it then reads really strange because of the "and" between the component names, doesn't it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, for me, the bridges are listed with components without making a distinction, so maybe we could just do the same here ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's actually mixed, isn't it? We have a serial comma in your description but no in @webmozart's.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reworded it to be a bit more natural at sha: 2a14bf3

I think we generally don't use serial commas, so the usage for Stof would be the one to change.


* **Christophe Coevoet** (:merger:`stof`) can merge into the BrowserKit_,
Config_, Console_, DependencyInjection_, DomCrawler_, EventDispatcher_,
Expand Down Expand Up @@ -164,3 +164,5 @@ discretion of the **Project Leader**.
.. _Stopwatch: https://github.com/symfony/Stopwatch
.. _TwigBridge: https://github.com/symfony/TwigBridge
.. _Validator: https://github.com/symfony/Validator
.. _VarDumper: https://github.com/symfony/var-dumper
.. _DebugBundle: https://github.com/symfony/debug-bundle