[Contributing] tweaks to the contribution chapter #4245
Conversation
|
|
||
| More than 800 developers all around the world have contributed to Symfony's | ||
| documentation, and we are glad that you are considering joining this big family. | ||
| More than 700 developers all around the world have contributed to Symfony's |
There was a problem hiding this comment.
In http://symfony.com/contributors/doc you can se that there are 794 people identified as documentation contributors. Don't you think it's better to say more than 800? Otherwise, this figure will be out-dated pretty soon.
There was a problem hiding this comment.
On https://github.com/symfony/symfony-docs, the number of contributors is 721. Do you know where the figure on symfony.com is coming from?
There was a problem hiding this comment.
@xabbuh the github UI counts the number of github accounts. symfony.com counts the number of distinct email addresses. So there is 2 sources of differences:
- people with several email addresses associated to their github account
- people contributing with an email address not associated to their github account
@javiereguiluz why would it be outdated ? 850 is still more than 700 😄. The only way it could be outdated is when the number of contributors become lower than 700, which is not possible
There was a problem hiding this comment.
If symfony.com counts unique e-mail addresses, the GitHub count seems more reasonable to me. For example, I used at least two different e-mail addresses in commit messages and I see no reason why this should be counted for two contributors.
Admittedly, this may look weird if people have at the contributors on symfony.com after reading this sentence. However, when you read this and then see the figure on GitHub, this seems even more weird. As @stof said, "more than 700" is true for both figures. :)
There was a problem hiding this comment.
OK, let's keep the low figure.
However, GitHub is a closed source service, which means that we don't know what they really do to count contributions. This help article explains some things, such as the cases where contributions aren't counted: https://help.github.com/articles/why-are-my-contributions-not-showing-up-on-my-profile
There was a problem hiding this comment.
the doc you linked talks about criteria for the contributions on the profile page. for repo contributors the rules are explained at https://help.github.com/articles/i-don-t-see-myself-in-the-repository-contributors-graph
the only case impacting us here is the case of email addresses not being linked to an account (and so ignored by github when building the list) or several addresses for the same user. The criteria about contributing to the default branch is not an issue given that other branches are merged in master regularly
xabbuh
force-pushed
the
pr-4223-tweaks
branch
from
46a9d6e to
2bbc76e
Compare
xabbuh
force-pushed
the
pr-4223-tweaks
branch
from
2bbc76e to
f4b0b8e
Compare
|
👍 nice improvements @xabbuh. Thanks! |
|
Very nice changes! Thanks Christian! |
This PR was merged into the 2.3 branch. Discussion ---------- [Contributing] tweaks to the contribution chapter | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | Some tweaks for the changes made in #4223. @javiereguiluz Sorry, didn't find the time to review it in the first run. Commits ------- f4b0b8e tweaks to the contribution chapter
Some tweaks for the changes made in #4223.
@javiereguiluz Sorry, didn't find the time to review it in the first run.