add note about parameters in imports #4226
Merged
+37
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Sep 13, 2014
xabbuh
commented
| Q | A |
|---|---|
| Doc fix? | yes |
| New docs? | no |
| Applies to | all |
| Fixed tickets | #4207 |
| @@ -0,0 +1,31 @@ | |||
| .. note:: | |||
|
|
|||
| Due to the order in which parameters are resolved, you cannot use them | |||
There was a problem hiding this comment.
"Due to the order in which [...]" This looks like you could make it work if you reordered your params or your import files. In my opinion the cause is not the order in which parameters are resolved but how they are resolved.
There was a problem hiding this comment.
Changed it to "Due to the way in which [...]".
|
👍 I think that this issue is now mergeable. Thanks @xabbuh. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.