[Components][DependencyInjection] do not reference services in parameters #4222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Sep 13, 2014
xabbuh
commented
| Q | A |
|---|---|
| Doc fix? | yes |
| New docs? | no |
| Applies to | all |
| Fixed tickets | #4211 |
|
we need to make sure that this syntax is still described when referencing services in arguments though |
|
This should be covered with the Types of Injection chapter. |
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Sep 13, 2014
… XSD (xabbuh) This PR was merged into the 2.3 branch. Discussion ---------- [DependencyInjection] remove `service` parameter type from XSD | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | symfony/symfony-docs#4222 Referencing a service in a parameter doesn't work and will lead to an error when the configuration is loaded (see symfony/symfony-docs#4211). Commits ------- 7333c2d remove `service` parameter type from XSD
|
Thanks for the detective work and fix for this "extra" feature :). Cheers! |
weaverryan
added a commit
that referenced
this pull request
Sep 16, 2014
… in parameters (xabbuh) This PR was merged into the 2.3 branch. Discussion ---------- [Components][DependencyInjection] do not reference services in parameters | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | #4211 Commits ------- 4b10abf do not reference services in parameters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.