tweaks to the new reverse proxy/load balancer chapter #4113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Aug 10, 2014
xabbuh
commented
| Q | A |
|---|---|
| Doc fix? | yes |
| New docs? | no |
| Applies to | all |
| Fixed tickets |
| @@ -163,7 +163,7 @@ The caching kernel will immediately act as a reverse proxy - caching responses | |||
| from your application and returning them to the client. | |||
|
|
|||
| Now that you're using a "proxy", you'll need to configure ``127.0.0.1`` under | |||
| the ``trusted_proxies`` configuration (see :ref:`reference <reference-framework-trusted-proxies>`). | |||
| the ``trusted_proxies`` configuration (see :ref:`the reference <reference-framework-trusted-proxies>`). | |||
There was a problem hiding this comment.
Not using framework.trusted_proxies as I first proposed here makes sense since the option name is already mentioned before in this sentence.
xabbuh
changed the title
Indent the complete block with three more spaces so that it is aligned properly inside the surrounding list item. Move placeholder comment to the right place.
|
Awesome - thanks for the tweaks. |
weaverryan
added a commit
that referenced
this pull request
Aug 15, 2014
…bbuh) This PR was merged into the 2.3 branch. Discussion ---------- tweaks to the new reverse proxy/load balancer chapter | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | Commits ------- bbc2f11 fix code block 6943da8 fix a headline 12840b1 improve linking between proxy config sections
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.