Skip to content

Added editorconfig #4044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 29, 2014
Merged

Added editorconfig #4044

merged 2 commits into from
Jul 29, 2014

Conversation

wouterj
Copy link
Member

@wouterj wouterj commented Jul 20, 2014

Q A
Doc fix? no
New docs? no
Applies to all
Fixed tickets -

EditorConfig is a very great project to maintain a
coding styles. It uses editor plugins for a dozen editors. This way, a file is
automatically fixed when the file is opened/written.

I think it'll be pretty usefull to use in the docs.

(fyi, symfony code has this for a long time already)

@javiereguiluz
Copy link
Member

👍 I like it! Thanks Wouter!

Just a question: the doc repository also includes some map.rst.inc files. Do we need to configure the settings for that extension as well or is not necessary?

@wouterj
Copy link
Member Author

wouterj commented Jul 23, 2014

@javiereguiluz good one! Added it :)

@weaverryan
Copy link
Member

Awesome, very cool idea :). Thanks Wouter!

@weaverryan weaverryan merged commit af8a4ce into symfony:2.3 Jul 29, 2014
weaverryan added a commit that referenced this pull request Jul 29, 2014
This PR was merged into the 2.3 branch.

Discussion
----------

Added editorconfig

| Q   | A
| --- | ---
| Doc fix? | no
| New docs? | no
| Applies to | all
| Fixed tickets | -

[EditorConfig](http://editorconfig.org/) is a very great project to maintain a
coding styles. It uses editor plugins for a dozen editors. This way, a file is
automatically fixed when the file is opened/written.

I think it'll be pretty usefull to use in the docs.

(fyi, symfony code has this for a long time already)

Commits
-------

af8a4ce Also apply it for .rst.inc files
7b78dc4 Added editorconfig
@wouterj wouterj deleted the editorconfig branch July 29, 2014 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants