Reorder page from simple to advanced (rebased) #3928
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a followup on symfony/symfony#10980 I want to propose to reorder the page as the obvious way should come first. I took me way to long to find the correct way :p I added two headers - The default ExceptionController - Override error templates in order to introduce how override works and moved the controller override to the bottom as that is more advanced.
|
Nice work Clemens - thanks! |
weaverryan
added a commit
that referenced
this pull request
Jun 11, 2014
…-tolboom) This PR was submitted for the 2.4 branch but it was merged into the 2.3 branch instead (closes #3928). Discussion ---------- Reorder page from simple to advanced (rebased) As #3910 got meshed up here is a cherrypicked version. === As a followup on symfony/symfony#10980 I want to propose to reorder the page as the obvious way should come first. I took me way to long to find the correct way :p I added two headers - The default ExceptionController - Override error templates in order to introduce how override works and moved the controller override to the bottom as that is more advanced. Fixes #3910 Commits ------- 13f5ec6 Fixed @weaverryan: backticks and rephase method overrides. 3ad1c6c Added feedback from @weaverryan with a little move around. 10ed835 Fixed feedback from @xabbuh: Templates 67e89af Fixed feedback from @xabbuh 334492a Reorder page from simple to advanced
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As #3910 got meshed up here is a cherrypicked version.
As a followup on symfony/symfony#10980 I want to propose to reorder the page as the obvious way should come first. I took me way to long to find the correct way :p
I added two headers
in order to introduce how override works and moved the controller override to the bottom as that is more advanced.
Fixes #3910