Skip to content

Update remove.rst #3924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions cookbook/bundles/remove.rst
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,11 @@ can remove the ``Acme`` directory as well.

echo $this->container->get('kernel')->getBundle('AcmeDemoBundle')->getPath();

3.1 Remove Bundle Resources
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say "Assets" instead of "Resources"

~~~~~~~~~~~~~~~~~~~~~~~~~~~

Remove the Acme resource directory from the application's web folder. It can be found in ``web/bundles/acmedemo``.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can be even more direct. What do you guys think about:

Remove the web/bundles/acmedemo directory. This contains the public assets (e.g CSS) for the bundle.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should also take care of the second goal of this article: talk about removing a bundle in general. So I would propose something along the lines of "Remove the assets of the bundle in the web/ directory (e.g. web/bundles/acmedemo)"

4. Remove integration in other bundles
--------------------------------------

Expand Down