-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[RFR] Misc. minor fixes mostly related to formatting issues #3899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
79bf0a1
00b3d26
dee3180
0554cae
4641c66
9a71577
314c131
81fe666
6625ff2
2deb5d7
3b557a0
e871a32
b223417
03b83ba
d38f00e
2442839
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1034,7 +1034,7 @@ Cache Invalidation | |
------------------ | ||
|
||
"There are only two hard things in Computer Science: cache invalidation | ||
and naming things." --Phil Karlton | ||
and naming things." — Phil Karlton | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. you used an em dash here. There are more places in the docs where the em dash should be used, but we used a hyphen instead there (because @weaverryan found it easier to just use the hyphen: #1637 (comment)) We should decided which dash we use and use that consistently in all docs There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You are right. I should always follow the style guide. Reverting this change. |
||
|
||
You should never need to invalidate cached data because invalidation is already | ||
taken into account natively in the HTTP cache models. If you use validation, | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -850,7 +850,9 @@ uses a simple string pattern called the *logical controller name*, which | |
Symfony maps to a specific PHP method and class. The pattern has three parts, | ||
each separated by a colon: | ||
|
||
**bundle**:**controller**:**action** | ||
.. code-block:: text | ||
|
||
bundle:controller:action | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why not the blockquote thing? It is because it's design will differ much from normal code blocks in the new design? Otherwise, I'm +1 for the previous way here because it wouldn't show the useless line numbers There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You are right again. The line numbers on single line code blocks are silly. Reverting to blockquote. |
||
|
||
For example, a ``_controller`` value of ``AcmeBlogBundle:Blog:show`` means: | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -287,12 +287,12 @@ The new environment is now accessible via:: | |
|
||
.. note:: | ||
|
||
Some environments, like the ``dev`` environment, are never meant to be | ||
accessed on any deployed server by the general public. This is because | ||
certain environments, for debugging purposes, may give too much information | ||
about the application or underlying infrastructure. To be sure these environments | ||
aren't accessible, the front controller is usually protected from external | ||
IP addresses via the following code at the top of the controller: | ||
Some environments, like the ``dev`` environment, are never meant to be | ||
accessed on any deployed server by the general public. This is because | ||
certain environments, for debugging purposes, may give too much information | ||
about the application or underlying infrastructure. To be sure these environments | ||
aren't accessible, the front controller is usually protected from external | ||
IP addresses via the following code at the top of the controller: | ||
|
||
.. code-block:: php | ||
|
||
|
@@ -315,8 +315,12 @@ However, each environment caches its own set of files: | |
|
||
.. code-block:: text | ||
|
||
app/cache/dev - cache directory for the *dev* environment | ||
app/cache/prod - cache directory for the *prod* environment | ||
<your-project>/ | ||
├─ app/ | ||
│ ├─ cache/ | ||
│ │ ├─ dev/ // cache directory for the *dev* environment | ||
│ │ └─ prod/ // cache directory for the *prod* environment | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. let's use the |
||
│ ├─ ... | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. unicode trees! :) |
||
|
||
Sometimes, when debugging, it may be helpful to inspect a cached file to | ||
understand how something is working. When doing so, remember to look in | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any special reason for the additional indentation on this line?