Skip to content

Add filter cssrewrite #3859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add filter cssrewrite #3859

wants to merge 1 commit into from

Conversation

DOEO
Copy link
Contributor

@DOEO DOEO commented May 21, 2014

@wouterj
Copy link
Member

wouterj commented May 21, 2014

This article is about the UglifyCSS filter (actually, it is about showing an example of custom build-in filters). I don't think it's usefull to use the cssrewrite filter in here, that's a complete different topic and it already has a section.

@DOEO
Copy link
Contributor Author

DOEO commented May 21, 2014

Yes but if you don't do this, image link is dead and you have to search why.

@weaverryan
Copy link
Member

Hi @DOEO! I agree with Wouter, but since this doesn't hurt anything, and since you really do always need cssrewrite, I think it makes sense to include it. It almost seems like it would be better if cssrewrite were always applied for stylesheets, though I'm not sure if this is possible (would be possible via an apply_to in config.yml to target CSS files, but I believe it would not work then with sass files, for example). Anyways, thanks for the PR!

weaverryan added a commit that referenced this pull request May 28, 2014
This PR was submitted for the 2.4 branch but it was merged into the 2.3 branch instead (closes #3859).

Discussion
----------

Add filter cssrewrite

According to : http://symfony.com/doc/current/cookbook/assetic/asset_management.html#cookbook-assetic-cssrewrite

For keep link to image in CSS

Commits
-------

0210a35 Add filter cssrewrite
@weaverryan weaverryan closed this May 28, 2014
@DOEO
Copy link
Contributor Author

DOEO commented May 28, 2014

Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants