Update dialoghelper.rst #3840
Closed
Update dialoghelper.rst #3840
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the "Validating a Hidden Response" the example validation didn't respond anything so the $password var was NULL
|
also applicable in the 2.3 branch |
| @@ -159,6 +159,7 @@ You can also ask and validate a hidden response:: | |||
| if (trim($value) == '') { | |||
| throw new \Exception('The password can not be empty'); | |||
| } | |||
| return $value; | |||
There was a problem hiding this comment.
there should be a new line before the return statement
|
@wouterj : maybe add a newline before line 120 also ? to stay in rule ? |
Indeed, I agree. |
|
Awesome fix! I've merged this now so we can get it in, but I also agree with the other line break. It's really tiny, so I'll make that change right now :). Thanks! |
weaverryan
added a commit
that referenced
this pull request
May 12, 2014
This PR was submitted for the 2.4 branch but it was merged into the 2.3 branch instead (closes #3840). Discussion ---------- Update dialoghelper.rst At the "Validating a Hidden Response" the example validation didn't respond anything so the $password var was NULL Commits ------- c1812a9 Update dialoghelper.rst 036d276 Update dialoghelper.rst
weaverryan
added a commit
that referenced
this pull request
May 12, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the "Validating a Hidden Response" the example validation didn't respond anything so the $password var was NULL