Add a note about which types can be used in Symfony #3802
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
| more subjective naming considerations; | ||
|
|
||
| * For type-hinting in PHPDocs and casting, PHP supports several alternatives | ||
| for some types but Symfony standardizes on one: use ``bool`` (instead of |
There was a problem hiding this comment.
We should make it consistent with the other standards and use something like "For type-hinting in PHPdocs and castings, use bool (instead of boolean or Boolean) [...]"
Also, I think this should be above the last item, since that one is kind of a "read more" item.
weaverryan
added a commit
that referenced
this pull request
May 8, 2014
This PR was merged into the 2.3 branch. Discussion ---------- Add a note about which types can be used in Symfony | Q | A | ------------- | --- | Doc fix? | no | New docs? | no | Applies to | all | Fixed tickets | n/a see symfony/symfony#10701 Commits ------- bf9d509 added a note about types we support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see symfony/symfony#10701