[Reference][Forms] move versionadded directives for form options directly below the option's headline #3790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree, this is better. Otherwise, you might not see the versionadded. Thanks! |
weaverryan
added a commit
that referenced
this pull request
May 10, 2014
…options directly below the option's headline (xabbuh) This PR was merged into the 2.3 branch. Discussion ---------- [Reference][Forms] move versionadded directives for form options directly below the option's headline | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | When you link directly to a form type option (for example, http://symfony.com/doc/current/reference/forms/types/form.html#action), the ``versionadded`` directive is rendered outside the user's view port which might confuse people. Thus, @wouterj and me decided to place ``versionadded`` directives for form type options directly below the option's headline (above the ``type`` line). Commits ------- 72c30c2 move versionadded directives for form options directly below the option's headline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you link directly to a form type option (for example, http://symfony.com/doc/current/reference/forms/types/form.html#action), the
versionaddeddirective is rendered outside the user's view port which might confuse people. Thus, @wouterj and me decided to placeversionaddeddirectives for form type options directly below the option's headline (above thetypeline).