Skip to content

Minor tweaks related to #3368 #3725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2014
Merged

Minor tweaks related to #3368 #3725

merged 1 commit into from
Mar 31, 2014

Conversation

weaverryan
Copy link
Member

Hi guys!

Q A
Doc fix? yes
New docs? no
Applies to 2.3

weaverryan added a commit that referenced this pull request Mar 31, 2014
@weaverryan
minor #3725 Minor tweaks related to #3368 (weaverryan)
d16be31 
This PR was merged into the 2.3 branch.

Discussion
----------

Minor tweaks related to #3368

Hi guys!

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | 2.3

Commits
-------

544a0f5 Minor tweaks related to #3368
@weaverryan weaverryan merged commit 544a0f5 into 2.3 Mar 31, 2014
@weaverryan weaverryan deleted the hostname-tweaks branch March 31, 2014 09:37
@wouterj
Copy link
Member

wouterj commented Mar 31, 2014

I would suggest to just do minor things via commits and only bigger changes using PRs. That'll make everything a lot easier for you and we (@xabbuh and I) don't really care which way you use :)

@xabbuh
Copy link
Member

xabbuh commented Mar 31, 2014

I agree with @wouterj.

@weaverryan
Copy link
Member Author

cool 👍 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@weaverryan @wouterj @xabbuh