Skip to content

Update security.rst #3636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Update security.rst #3636

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c8c093a
Update security.rst
Mar 4, 2014
1c2abab
Improved the sentence
alvarezmario Mar 27, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion book/security.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ perform a certain action.
.. image:: /images/book/security_authentication_authorization.png
:align: center

Since the best way to learn is to see an example, start by securing your
Since the best way to learn is to see an example, let's start by securing your
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our standard is to avoid the first person perspective.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with both of you, we should avoid the first person, but the current sentence really needs a first person perspective here. So we have to rewrite the complete sentence.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ha, I'm also struggling a bit here :).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the best way to learn is to see an example, just imagine that you want to secure your application with HTTP Basic authentication.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea, that's really great!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ping @Nomack84 - do you want to make the change suggested by @xabbuh?

Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weaverryan I'll close this PR because I did it with the edit featured of GitHub and I'll create a new one with this change by @xabbuh

application with HTTP Basic authentication.

.. note::
Expand Down