Added documentation for missing ctype extension #3601
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * `upper <http://php.net/function.ctype-upper.php>`_ | ||
| * `xdigit <http://php.net/function.ctype-xdigit.php>`_ | ||
|
|
||
| Make sure that proper `locale <http://php.net/function.setlocale.php>`_ is set before using one of those. |
There was a problem hiding this comment.
Make sure that the proper...
... before using one of these.
|
@slavafomin 👍 I didn't know about this feature :). I've just added a few notes, and can you also move the links to the bottom of the page. Your syntax for external links is correct, we just have a standard of putting all the URLs at the bottom of each file. Thanks! |
| * `punct <http://php.net/function.ctype-punct.php>`_ | ||
| * `space <http://php.net/function.ctype-space.php>`_ | ||
| * `upper <http://php.net/function.ctype-upper.php>`_ | ||
| * `xdigit <http://php.net/function.ctype-xdigit.php>`_ |
There was a problem hiding this comment.
instead of the links, you should use the :phpfunction: role:
* :phpfunction:`ctype_alnum`
* :phpfunction:`ctype_alpha`
* ...Or if you don't want to use the function name:
* :phpfunction:`alnum <ctype_alnum>`
* :phpfunction:`alpha <ctype_alpha>`
* ...
added 2 commits
March 11, 2014 13:36
Fixed spelling.
Updated references to PHP functions using syntax suggested by @wouterj (`:phpfunction:` role).
|
@weaverryan, @wouterj thanks for suggestions! I've introduced necessary changes. I hope my syntax is correct. |
|
It looks great. Thanks so much for adding these details and making prompt tweakss ! Cheers Slava! |
weaverryan
added a commit
that referenced
this pull request
Mar 13, 2014
…omin) This PR was submitted for the 2.4 branch but it was merged into the 2.3 branch instead (closes #3601). Discussion ---------- Added documentation for missing ctype extension Commits ------- 51cfb23 Updated references to PHP functions bc439ff Fixed spelling 1d03b0e Added documentation for missing ctype extension
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.