Skip to content

[Book][Security] remove duplicate label #3524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Jan 29, 2014

Q A
Doc fix? yes
New docs? no
Applies to 2.5
Fixed tickets

This has been previously fixed in #3456 but somehow slipped through in 8bd668e.

@cordoval
Copy link
Contributor

I wonder why things slip in that way, maybe because of the order of commits or lack of rebase, lack of ripple merging of PRs to older bases? or merges across branches?

@xabbuh
Copy link
Member Author

xabbuh commented Jan 29, 2014

Yeah, as you can see in the commit mentioned in the PR description, there have been conflicts. Thus, I guess this slipped through when the conflicts were resolved.

For things like this which fix build errors, having the Travis integration running would ease Ryan's work.

@cordoval
Copy link
Contributor

yes i agree. I was wondering if there could be a messup detector as well, like identifying the duplicate lines for instance. he I am always now thinking where can Gush commands help.

@weaverryan
Copy link
Member

The line is gone now in master, I think it was simply a lack of me merging the branches up on a timely basis :). But nothing weird is going on.

@xabbuh but yes, I'm excited for the Travis integration - I'm going to find time soon to get that merged in - it will be really great!

@weaverryan weaverryan closed this Feb 4, 2014
@xabbuh xabbuh deleted the remove-duplicate-security-label branch February 4, 2014 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants