Skip to content

Add 'in XML' for additional clarity #3508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 3, 2014
Merged

Add 'in XML' for additional clarity #3508

merged 2 commits into from
Feb 3, 2014

Conversation

ifdattic
Copy link
Contributor

Q A
Doc fix? yes
New docs? no
Applies to 2.3
Fixed tickets

@@ -399,7 +399,7 @@ process is used to remove some of the differences that result from different
configuration formats, mainly the differences between YAML and XML.

The separator used in keys is typically ``_`` in YAML and ``-`` in XML. For
example, ``auto_connect`` in YAML and ``auto-connect``. The normalization would
example, ``auto_connect`` in YAML and ``auto-connect`` in XML. The normalization would
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the line break should also be adjusted to comply with the 72th character rule

@weaverryan
Copy link
Member

Agreed - it didn't sound well before - this is much more clear. Thanks!

weaverryan added a commit that referenced this pull request Feb 3, 2014
This PR was merged into the 2.3 branch.

Discussion
----------

Add 'in XML' for additional clarity

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | 2.3
| Fixed tickets |

Commits
-------

69d9277 Adjust line length
100a031 Add 'in XML' for additional clarity
@weaverryan weaverryan merged commit 69d9277 into symfony:2.3 Feb 3, 2014
@ifdattic ifdattic deleted the changes-to-components-config-definition branch February 3, 2014 07:20
@ifdattic
Copy link
Contributor Author

ifdattic commented Feb 3, 2014

Yes, it was still possible to understand, but just felt that something is missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants