[Reference][Form Types] Add missing "format" option to "datetime" field #3466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bicpi
commented
Jan 11, 2014
bicpi
commented
| Q | A |
|---|---|
| Doc fix? | no |
| New docs? | yes |
| Applies to | 2.3+ |
| Fixed tickets | #3410 |
| the format of the input, i.e. how Symfony will interpret the given input | ||
| as a datetime string. It defaults to the `RFC 3339`_ format which is used | ||
| by the HTML5 ``datetime`` field. Keeping the default will render a field of | ||
| type ``datetime``. |
There was a problem hiding this comment.
This is an important note, and I think we can be even more specific on what we mean:
Keeping the default value will cause the field to be rendered as an ``input`` field with ``type="datetime"``.
There was a problem hiding this comment.
@weaverryan Adopted your proposal, sounds good, thanks. And it's really important to know when exactly you get thedatetime field type :-)
weaverryan
added a commit
that referenced
this pull request
Feb 1, 2014
…options [Reference][Form Types] Add missing "format" option to "datetime" field
|
👍 great work on this Philipp - I think it's tricky to describe just right :). Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.